Deal with older dbal versiosn

phpstan · Feb 9, 2024 · e5cab77 · e5cab77
1 parent 462d7c1
commit e5cab77
Show file tree

Hide file tree

Showing 2 changed files with 102 additions and 0 deletions.
diff --git a/tests/Rules/Doctrine/DBAL/ArrayParameterTypeRuleTest.php b/tests/Rules/Doctrine/DBAL/ArrayParameterTypeRuleTest.php
@@ -2,6 +2,8 @@
 
 namespace PHPStan\Rules\Doctrine\DBAL;
 
+use Composer\InstalledVersions;
+use Composer\Semver\VersionParser;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 
@@ -11,8 +13,44 @@
 final class ArrayParameterTypeRuleTest extends RuleTestCase
 {
 
+	public function testRuleOlderDbal(): void
+	{
+		if(InstalledVersions::satisfies(
+			new VersionParser(),
+			'doctrine/dbal',
+			'^3.6 || ^4.0'
+		)) {
+			self::markTestSkipped('Test requires dbal 2.');
+		}
+		$this->analyse([__DIR__ . '/data/connection_dbal2.php'], [
+			[
+				'Parameter at 0 is an array, but is not hinted as such to doctrine.',
+				10,
+			],
+			[
+				"Parameter at 'a' is an array, but is not hinted as such to doctrine.",
+				19,
+			],
+			[
+				"Parameter at 'a' is an array, but is not hinted as such to doctrine.",
+				28,
+			],
+			[
+				"Parameter at 'a' is an array, but is not hinted as such to doctrine.",
+				39,
+			],
+		]);
+	}
+
 	public function testRule(): void
 	{
+		if(InstalledVersions::satisfies(
+			new VersionParser(),
+			'doctrine/dbal',
+			'<3.6'
+		)) {
+			self::markTestSkipped('Test requires dbal 3 or 4.');
+		}
 		$this->analyse([__DIR__ . '/data/connection.php'], [
 			[
 				'Parameter at 0 is an array, but is not hinted as such to doctrine.',

diff --git a/tests/Rules/Doctrine/DBAL/data/connection_dbal2.php b/tests/Rules/Doctrine/DBAL/data/connection_dbal2.php
@@ -0,0 +1,64 @@
+<?php
+
+namespace PHPStan\Rules\Doctrine\DBAL;
+
+use Doctrine\DBAL\Connection;
+use Doctrine\DBAL\ParameterType;
+
+function check(Connection  $connection, array $data) {
+
+	$connection->executeQuery(
+		'SELECT 1 FROM table WHERE a IN (?) AND b = ?',
+		[
+
+			$data,
+			3
+		]
+	);
+
+	$connection->fetchOne(
+		'SELECT 1 FROM table WHERE a IN (:a) AND b = :b',
+		[
+
+			'a' => $data,
+			'b' => 3
+		]
+	);
+
+	$connection->fetchOne(
+		'SELECT 1 FROM table WHERE a IN (:a) AND b = :b',
+		[
+			'a' => $data,
+			'b' => 3
+		],
+		[
+			'b' => ParameterType::INTEGER,
+		]
+	);
+
+	$connection->fetchOne(
+		'SELECT 1 FROM table WHERE a IN (:a) AND b = :b',
+		[
+			'a' => $data,
+			'b' => 3
+		],
+		[
+			'a' => ParameterType::INTEGER,
+			'b' => ParameterType::INTEGER,
+		]
+	);
+
+
+	$connection->fetchOne(
+		'SELECT 1 FROM table WHERE a IN (:a) AND b = :b',
+		[
+			'a' => $data,
+			'b' => 3
+		],
+		[
+			'a' => Connection::PARAM_INT_ARRAY,
+			'b' => ParameterType::INTEGER,
+		]
+	);
+
+}