Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reproducer] QueryBuilder DQL is not reported correctly when QB is pased around #80

Open
wants to merge 1 commit into
base: 1.3.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public function dataTopics(): array
['entityManagerMergeReturn'],
['customRepositoryUsage'],
['queryBuilder'],
['queryBuilderExtraMethod'],
];
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[
]
49 changes: 49 additions & 0 deletions tests/DoctrineIntegration/ORM/data/queryBuilderExtraMethod.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?php declare(strict_types = 1);

namespace PHPStan\DoctrineIntegration\ORM\QueryBuilder;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Query;
use Doctrine\ORM\QueryBuilder;
use PHPStan\DoctrineIntegration\ORM\CustomRepositoryUsage\MyEntity;

class Foo
{

/**
* @var EntityManager
*/
private $entityManager;

public function __construct(EntityManager $entityManager)
{
$this->entityManager = $entityManager;
}

public function doFoo(): Query
{
$queryBuilder = $this->entityManager->createQueryBuilder()
->select('e')
->from(MyEntity::class, 'e');

// @todo it works when the extra where is here
//$queryBuilder->andWhere('e.id != :excludedId');

// but it does not work when the where is added in extra method
$this->addExtraCondition($queryBuilder);

$query = $queryBuilder->getQuery();

$expectedDql = 'SELECT e FROM PHPStan\DoctrineIntegration\ORM\CustomRepositoryUsage\MyEntity e WHERE e.id != :excludedId';
$query->getDQL() === $expectedDql;
$queryBuilder->getDQL() === $expectedDql;

return $query;
}

private function addExtraCondition(QueryBuilder $queryBuilder): void
{
$queryBuilder->andWhere('e.id != :excludedId');
}

}