Narrow type on assertCount and assertNotCount

phpstan · Feb 23, 2024 · d5242a5 · d5242a5
1 parent 70ecacc
commit d5242a5
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/src/Type/PHPUnit/Assert/AssertTypeSpecifyingExtensionHelper.php b/src/Type/PHPUnit/Assert/AssertTypeSpecifyingExtensionHelper.php
@@ -136,6 +136,20 @@ private static function getExpressionResolvers(): array
 	{
 		if (self::$resolvers === null) {
 			self::$resolvers = [
+				'Count' => static function (Scope $scope, Arg $expected, Arg $actual): Identical {
+					return new Identical(
+						$expected->value,
+						new FuncCall(new Name('count'), [$actual])
+					);
+				},
+				'NotCount' => static function (Scope $scope, Arg $expected, Arg $actual): BooleanNot {
+					return new BooleanNot(
+						new Identical(
+							$expected->value,
+							new FuncCall(new Name('count'), [$actual])
+						)
+					);
+				},
 				'InstanceOf' => static function (Scope $scope, Arg $class, Arg $object): Instanceof_ {
 					return new Instanceof_(
 						$object->value,

diff --git a/tests/Type/PHPUnit/data/assert-function.php b/tests/Type/PHPUnit/data/assert-function.php
@@ -7,6 +7,8 @@
 use function PHPUnit\Framework\assertContains;
 use function PHPUnit\Framework\assertContainsEquals;
 use function PHPUnit\Framework\assertContainsOnlyInstancesOf;
+use function PHPUnit\Framework\assertCount;
+use function PHPUnit\Framework\assertNotCount;
 use function PHPUnit\Framework\assertEmpty;
 use function PHPUnit\Framework\assertInstanceOf;
 use function PHPUnit\Framework\assertObjectHasAttribute;
@@ -90,4 +92,23 @@ public function containsOnlyInstancesOf(array $a, \Traversable $b): void
 		assertType('Traversable', $b);
 	}
 
+	public function count(array $a, \Countable $b): void
+	{
+		assertCount(3, $a);
+		assertType('non-empty-array', $a);
+
+		assertCount(7, $b);
+		assertType('Countable', $b);
+	}
+
+	public function notCount(array $a, array $b): void
+	{
+		assertNotCount(0, $a);
+		assertType('non-empty-array', $a);
+
+		// still might be empty
+		assertNotCount(1, $b);
+		assertType('array', $b);
+	}
+
 }