Skip to content

Commit

Permalink
Don't use abstract private method in trait
Browse files Browse the repository at this point in the history
  • Loading branch information
rvanvelzen committed Apr 29, 2022
1 parent be17f0a commit 1b7da5f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/Type/ConditionalType.php
Expand Up @@ -86,7 +86,7 @@ public function isResolvable(): bool
return !TypeUtils::containsTemplateType($this->subject) && !TypeUtils::containsTemplateType($this->target);
}

private function getResult(): Type
protected function getResult(): Type
{
$isSuperType = $this->target->isSuperTypeOf($this->subject);

Expand Down
2 changes: 1 addition & 1 deletion src/Type/ConditionalTypeForParameter.php
Expand Up @@ -106,7 +106,7 @@ public function isResolvable(): bool
return false;
}

private function getResult(): Type
protected function getResult(): Type
{
return TypeCombinator::union($this->if, $this->else);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Type/Traits/LateResolvableTypeTrait.php
Expand Up @@ -292,6 +292,6 @@ public function resolve(): Type
return $this->result;
}

abstract private function getResult(): Type;
abstract protected function getResult(): Type;

}

0 comments on commit 1b7da5f

Please sign in to comment.