remove unnecessary unset()

phpstan · Nov 3, 2023 · 1cf1a08 · 1cf1a08
1 parent 5ed3fea
commit 1cf1a08
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -3850,10 +3850,6 @@ public function filterBySpecifiedTypes(SpecifiedTypes $specifiedTypes): self
 					);
 				} else {
 					$scope = $scope->unsetExpression($expr);
-					$exprString = $this->getNodeKey($expr);
-
-					unset($scope->expressionTypes[$exprString]);
-					unset($scope->nativeExpressionTypes[$exprString]);
 				}
 
 				continue;

diff --git a/tests/PHPStan/Analyser/data/falsey-isset-certainty.php b/tests/PHPStan/Analyser/data/falsey-isset-certainty.php
@@ -174,6 +174,7 @@ function falseySubtractedMixedIssetVariable(): void
 
 	assertVariableCertainty(TrinaryLogic::createMaybe(), $a);
 }
+
 function falseyIssetWithAssignment(): void
 {
 	if (rand() % 2) {