Fix CURLOPT_POSTFIELDS param type

phpstan · Oct 2, 2022 · 228a345 · 228a345
1 parent 1c9f57c
commit 228a345
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/src/Reflection/ParametersAcceptorSelector.php b/src/Reflection/ParametersAcceptorSelector.php
@@ -646,7 +646,6 @@ private static function getCurlOptValueType(int $curlOpt): ?Type
 			'CURLOPT_KRB4LEVEL',
 			'CURLOPT_LOGIN_OPTIONS',
 			'CURLOPT_PINNEDPUBLICKEY',
-			'CURLOPT_POSTFIELDS',
 			'CURLOPT_PRIVATE',
 			'CURLOPT_PRE_PROXY',
 			'CURLOPT_PROXY',
@@ -724,6 +723,18 @@ private static function getCurlOptValueType(int $curlOpt): ?Type
 			}
 		}
 
+		$arrayOrStringConstants = [
+			'CURLOPT_POSTFIELDS',
+		];
+		foreach ($arrayOrStringConstants as $constName) {
+			if (defined($constName) && constant($constName) === $curlOpt) {
+				return new UnionType([
+					new StringType(),
+					new ArrayType(new MixedType(), new MixedType()),
+				]);
+			}
+		}
+
 		$resourceConstants = [
 			'CURLOPT_FILE',
 			'CURLOPT_INFILE',

diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -1213,6 +1213,10 @@ public function testCurlSetOpt(): void
 				'Parameter #3 $value of function curl_setopt expects resource, string given.',
 				24,
 			],
+			[
+				'Parameter #3 $value of function curl_setopt expects array|string, int given.',
+				26,
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/Functions/data/curl_setopt.php b/tests/PHPStan/Rules/Functions/data/curl_setopt.php
@@ -22,6 +22,8 @@ public function errors(int $i, string $s) {
 		curl_setopt($curl, CURLOPT_CONNECT_TO, $s);
 		// expecting resource
 		curl_setopt($curl, CURLOPT_FILE, $s);
+		// expecting string or array
+		curl_setopt($curl, CURLOPT_POSTFIELDS, $i);
 	}
 
 	/**
@@ -45,5 +47,8 @@ public function allGood(string $url, array $header) {
 		curl_setopt($curl, CURLOPT_FILE, $fp);
 		curl_setopt($curl, CURLOPT_HEADER, false);
 		curl_setopt($curl, CURLOPT_HTTPHEADER, array('Content-type: text/plain', 'Content-length: 100'));
+		curl_setopt($curl, CURLOPT_POSTFIELDS, array('foo' => 'bar'));
+		curl_setopt($curl, CURLOPT_POSTFIELDS, '');
+		curl_setopt($curl, CURLOPT_POSTFIELDS, 'para1=val1&para2=val2');
 	}
 }