Implement MethodVisibitiliyInInterfaceRule

conf/config.level0.neon

@@ -82,13 +82,13 @@ rules:
 	- PHPStan\Rules\Keywords\ContinueBreakInLoopRule
 	- PHPStan\Rules\Methods\AbstractMethodInNonAbstractClassRule
 	- PHPStan\Rules\Methods\AbstractPrivateMethodRule
-	- PHPStan\Rules\Methods\AbstractProtectedMethodRule
 	- PHPStan\Rules\Methods\CallMethodsRule
 	- PHPStan\Rules\Methods\CallStaticMethodsRule
 	- PHPStan\Rules\Methods\ConstructorReturnTypeRule
 	- PHPStan\Rules\Methods\ExistingClassesInTypehintsRule
 	- PHPStan\Rules\Methods\FinalPrivateMethodRule
 	- PHPStan\Rules\Methods\MethodCallableRule
+	- PHPStan\Rules\Methods\MethodVisibitiliyInInterfaceRule
 	- PHPStan\Rules\Methods\MissingMethodImplementationRule
 	- PHPStan\Rules\Methods\MethodAttributesRule
 	- PHPStan\Rules\Methods\StaticMethodCallableRule

src/Rules/Methods/AbstractProtectedMethodRule.php → src/Rules/Methods/MethodVisibitiliyInInterfaceRule.php

@@ -10,7 +10,7 @@
 use function sprintf;
 
 /** @implements Rule<InClassMethodNode> */
-class AbstractProtectedMethodRule implements Rule
+class MethodVisibitiliyInInterfaceRule implements Rule
 {
 
 	public function getNodeType(): string
@@ -22,11 +22,7 @@ public function processNode(Node $node, Scope $scope): array
 	{
 		$method = $node->getMethodReflection();
 
-		if ($method->isPrivate() || $method->isPublic()) {
-			return [];
-		}
-
-		if (!$method->isAbstract()->yes()) {
+		if ($method->isPublic()) {
 			return [];
 		}
 
@@ -41,7 +37,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		return [
 			RuleErrorBuilder::message(sprintf(
-				'Protected method %s::%s() cannot be abstract.',
+				'Method %s::%s() cannot use non-public visibility in interface.',
 				$method->getDeclaringClass()->getDisplayName(),
 				$method->getName(),
 			))->nonIgnorable()->build(),

tests/PHPStan/Rules/Methods/AbstractPrivateMethodRuleTest.php

@@ -16,7 +16,7 @@ protected function getRule(): Rule
 
 	public function testRule(): void
 	{
-		$this->analyse([__DIR__ . '/data/abstract-methods.php'], [
+		$this->analyse([__DIR__ . '/data/abstract-private-method.php'], [
 			[
 				'Private method AbstractMethods\HelloWorld::sayPrivate() cannot be abstract.',
 				12,

tests/PHPStan/Rules/Methods/MethodVisibitiliyInInterfaceRuleTest.php

@@ -0,0 +1,31 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Methods;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/** @extends RuleTestCase<MethodVisibitiliyInInterfaceRule> */
+class MethodVisibitiliyInInterfaceRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new MethodVisibitiliyInInterfaceRule();
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/visibility-in-interace.php'], [
+			[
+				'Method VisibilityInInterface\FooInterface::sayPrivate() cannot use non-public visibility in interface.',
+				7,
+			],
+			[
+				'Method VisibilityInInterface\FooInterface::sayProtected() cannot use non-public visibility in interface.',
+				8,
+			],
+		]);
+	}
+
+}

tests/PHPStan/Rules/Methods/data/visibility-in-interace.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace VisibilityInInterface;
+
+interface FooInterface
+{
+	private function sayPrivate() : void;
+	protected function sayProtected() : void;
+	public function sayPublic() : void;
+
+	function noVisibility() : void;
+}
+
+trait FooTrait
+{
+	private function sayPrivate() : void {}
+	protected function sayProtected() : void {}
+	public function sayPublic() : void {}
+
+	function noVisibility() : void {}
+}
+
+abstract class AbstractFoo
+{
+	abstract private function sayPrivate() : void;
+	abstract protected function sayProtected() : void;
+	abstract public function sayPublic() : void;
+
+	abstract function noVisibility() : void;
+}