Skip to content

Commit

Permalink
Use readonly properties
Browse files Browse the repository at this point in the history
  • Loading branch information
ondrejmirtes committed Sep 27, 2022
1 parent 8a314f4 commit 432772a
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 18 deletions.
5 changes: 5 additions & 0 deletions build/rector-downgrade.php
Expand Up @@ -12,6 +12,7 @@
use Rector\DowngradePhp80\Rector\FunctionLike\DowngradeMixedTypeDeclarationRector;
use Rector\DowngradePhp80\Rector\FunctionLike\DowngradeUnionTypeDeclarationRector;
use Rector\DowngradePhp80\Rector\Property\DowngradeUnionTypeTypedPropertyRector;
use Rector\DowngradePhp81\Rector\Property\DowngradeReadonlyPropertyRector;

return static function (RectorConfig $config): void {
$parsePhpVersion = static function (string $version, int $defaultPatch = 0): int {
Expand All @@ -27,6 +28,10 @@
$config->phpVersion($targetPhpVersionId);
$config->skip(RectorCache::SKIP_PATHS);

if ($targetPhpVersionId < 80100) {
$config->rule(DowngradeReadonlyPropertyRector::class);
}

if ($targetPhpVersionId < 80000) {
$config->rule(DowngradeTrailingCommasInParamUseRector::class);
$config->rule(DowngradeNonCapturingCatchesRector::class);
Expand Down
36 changes: 18 additions & 18 deletions src/Analyser/NodeScopeResolver.php
Expand Up @@ -188,24 +188,24 @@ class NodeScopeResolver
* @param array<int, string> $earlyTerminatingFunctionCalls
*/
public function __construct(
private ReflectionProvider $reflectionProvider,
private InitializerExprTypeResolver $initializerExprTypeResolver,
private Reflector $reflector,
private ClassReflectionExtensionRegistryProvider $classReflectionExtensionRegistryProvider,
private Parser $parser,
private FileTypeMapper $fileTypeMapper,
private StubPhpDocProvider $stubPhpDocProvider,
private PhpVersion $phpVersion,
private PhpDocInheritanceResolver $phpDocInheritanceResolver,
private FileHelper $fileHelper,
private TypeSpecifier $typeSpecifier,
private DynamicThrowTypeExtensionProvider $dynamicThrowTypeExtensionProvider,
private ReadWritePropertiesExtensionProvider $readWritePropertiesExtensionProvider,
private bool $polluteScopeWithLoopInitialAssignments,
private bool $polluteScopeWithAlwaysIterableForeach,
private array $earlyTerminatingMethodCalls,
private array $earlyTerminatingFunctionCalls,
private bool $implicitThrows,
private readonly ReflectionProvider $reflectionProvider,
private readonly InitializerExprTypeResolver $initializerExprTypeResolver,
private readonly Reflector $reflector,
private readonly ClassReflectionExtensionRegistryProvider $classReflectionExtensionRegistryProvider,
private readonly Parser $parser,
private readonly FileTypeMapper $fileTypeMapper,
private readonly StubPhpDocProvider $stubPhpDocProvider,
private readonly PhpVersion $phpVersion,
private readonly PhpDocInheritanceResolver $phpDocInheritanceResolver,
private readonly FileHelper $fileHelper,
private readonly TypeSpecifier $typeSpecifier,
private readonly DynamicThrowTypeExtensionProvider $dynamicThrowTypeExtensionProvider,
private readonly ReadWritePropertiesExtensionProvider $readWritePropertiesExtensionProvider,
private readonly bool $polluteScopeWithLoopInitialAssignments,
private readonly bool $polluteScopeWithAlwaysIterableForeach,
private readonly array $earlyTerminatingMethodCalls,
private readonly array $earlyTerminatingFunctionCalls,
private readonly bool $implicitThrows,
)
{
$earlyTerminatingMethodNames = [];
Expand Down

0 comments on commit 432772a

Please sign in to comment.