fix: callable and iterable are maybe not isOffsetAccessLegal

phpstan · May 7, 2024 · 4b4af8e · 4b4af8e
1 parent dbfc3b8
commit 4b4af8e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/Type/CallableType.php b/src/Type/CallableType.php
@@ -326,7 +326,7 @@ public function toArrayKey(): Type
 
 	public function isOffsetAccessLegal(): TrinaryLogic
 	{
-		return TrinaryLogic::createYes();
+		return TrinaryLogic::createMaybe();
 	}
 
 	public function getTemplateTypeMap(): TemplateTypeMap

diff --git a/src/Type/IterableType.php b/src/Type/IterableType.php
@@ -244,7 +244,7 @@ public function toArrayKey(): Type
 
 	public function isOffsetAccessLegal(): TrinaryLogic
 	{
-		return TrinaryLogic::createYes();
+		return TrinaryLogic::createMaybe();
 	}
 
 	public function isIterable(): TrinaryLogic

diff --git a/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php b/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php
@@ -678,6 +678,10 @@ public function testBug8068(): void
 				"Cannot access offset 'path' on Closure.",
 				18,
 			],
+			[
+				"Cannot access offset 'path' on iterable<int|string, object>.",
+				26,
+			],
 		]);
 	}