Prevent repetative calls to Type::getConstantArrays()

phpstan · Jan 11, 2024 · 6d11aa9 · 6d11aa9
1 parent 52e2406
commit 6d11aa9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -1401,9 +1401,10 @@ private function resolveType(string $exprString, Expr $node): Type
 			return $this->initializerExprTypeResolver->getType($node, InitializerExprContext::fromScope($this));
 		} elseif ($node instanceof Object_) {
 			$castToObject = static function (Type $type): Type {
-				if (count($type->getConstantArrays()) > 0) {
+				$constantArrays = $type->getConstantArrays();
+				if (count($constantArrays) > 0) {
 					$objects = [];
-					foreach ($type->getConstantArrays() as $constantArray) {
+					foreach ($constantArrays as $constantArray) {
 						$properties = [];
 						$optionalProperties = [];
 						foreach ($constantArray->getKeyTypes() as $i => $keyType) {

diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -2134,11 +2134,12 @@ static function (): void {
 			) {
 				$extractedArg = $expr->getArgs()[0]->value;
 				$extractedType = $scope->getType($extractedArg);
-				if (count($extractedType->getConstantArrays()) > 0) {
+				$constantArrays = $extractedType->getConstantArrays();
+				if (count($constantArrays) > 0) {
 					$properties = [];
 					$optionalProperties = [];
 					$refCount = [];
-					foreach ($extractedType->getConstantArrays() as $constantArray) {
+					foreach ($constantArrays as $constantArray) {
 						foreach ($constantArray->getKeyTypes() as $i => $keyType) {
 							if ($keyType->isString()->no()) {
 								// integers as variable names not allowed
@@ -2160,7 +2161,7 @@ static function (): void {
 						}
 					}
 					foreach ($properties as $name => $type) {
-						$optional = in_array($name, $optionalProperties, true) || $refCount[$name] < count($extractedType->getConstantArrays());
+						$optional = in_array($name, $optionalProperties, true) || $refCount[$name] < count($constantArrays);
 						$scope = $scope->assignVariable($name, $type, $type, $optional ? TrinaryLogic::createMaybe() : TrinaryLogic::createYes());
 					}
 				} else {
@@ -2995,8 +2996,9 @@ private function getArrayFunctionAppendingType(FunctionReflection $functionRefle
 			foreach ($callArgs as $callArg) {
 				$callArgType = $scope->getType($callArg->value);
 				if ($callArg->unpack) {
-					if (count($callArgType->getConstantArrays()) === 1) {
-						$iterableValueTypes = $callArgType->getConstantArrays()[0]->getValueTypes();
+					$constantArrays = $callArgType->getConstantArrays();
+					if (count($constantArrays) === 1) {
+						$iterableValueTypes = $constantArrays[0]->getValueTypes();
 					} else {
 						$iterableValueTypes = [$callArgType->getIterableValueType()];
 						$nonConstantArrayWasUnpacked = true;

diff --git a/src/Reflection/InitializerExprTypeResolver.php b/src/Reflection/InitializerExprTypeResolver.php
@@ -501,8 +501,9 @@ public function getArrayType(Expr\Array_ $expr, callable $getTypeCallback): Type
 
 			$valueType = $getTypeCallback($arrayItem->value);
 			if ($arrayItem->unpack) {
-				if (count($valueType->getConstantArrays()) === 1) {
-					$constantArrayType = $valueType->getConstantArrays()[0];
+				$constantArrays = $valueType->getConstantArrays();
+				if (count($constantArrays) === 1) {
+					$constantArrayType = $constantArrays[0];
 					$hasStringKey = false;
 					foreach ($constantArrayType->getKeyTypes() as $keyType) {
 						if ($keyType->isString()->yes()) {