Do not call CollectedDataNode rules if internal errors are present

phpstan · Oct 3, 2022 · 8778350 · 8778350
1 parent fc0f990
commit 8778350
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/Command/AnalyseApplication.php b/src/Command/AnalyseApplication.php
@@ -104,10 +104,13 @@ public function analyse(
 			$analyserResult = $resultCacheResult->getAnalyserResult();
 			$internalErrors = $analyserResult->getInternalErrors();
 			$errors = $analyserResult->getErrors();
-			foreach ($this->getCollectedDataErrors($analyserResult->getCollectedData()) as $error) {
-				$errors[] = $error;
+			$hasInternalErrors = count($internalErrors) > 0 || $analyserResult->hasReachedInternalErrorsCountLimit();
+			if (!$hasInternalErrors) {
+				foreach ($this->getCollectedDataErrors($analyserResult->getCollectedData()) as $error) {
+					$errors[] = $error;
+				}
 			}
-			$errors = $ignoredErrorHelperResult->process($errors, $onlyFiles, $files, count($internalErrors) > 0 || $analyserResult->hasReachedInternalErrorsCountLimit());
+			$errors = $ignoredErrorHelperResult->process($errors, $onlyFiles, $files, $hasInternalErrors);
 			$collectedData = $analyserResult->getCollectedData();
 			$savedResultCache = $resultCacheResult->isSaved();
 			if ($analyserResult->hasReachedInternalErrorsCountLimit()) {