Regression test

Closes phpstan/phpstan#10201
phpstan · Nov 27, 2023 · 8ae98de · 8ae98de
1 parent 0177e33
commit 8ae98de
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 0 deletions.
diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -41,6 +41,7 @@ public function dataFileAsserts(): iterable
 		if (PHP_VERSION_ID >= 80100) {
 			yield from $this->gatherAssertTypes(__DIR__ . '/data/generic-enum-class-string.php');
 			yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7162.php');
+			yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-10201.php');
 		}
 
 		require_once __DIR__ . '/data/generic-generalization.php';

diff --git a/tests/PHPStan/Analyser/data/bug-10201.php b/tests/PHPStan/Analyser/data/bug-10201.php
@@ -0,0 +1,22 @@
+<?php // lint >= 8.1
+
+namespace Bug10201;
+
+use function PHPStan\Testing\assertType;
+
+enum Hello
+{
+	case Hi;
+}
+
+function bla(null|string|Hello $hello): void {
+	if (!in_array($hello, [Hello::Hi, null], true) && !($hello instanceof Hello)) {
+		assertType('string', $hello);
+	}
+}
+
+function bla2(null|string|Hello $hello): void {
+	if (!in_array($hello, [Hello::Hi, null], true)) {
+		assertType('string', $hello);
+	}
+}
diff --git a/tests/PHPStan/Rules/Classes/ImpossibleInstanceOfRuleTest.php b/tests/PHPStan/Rules/Classes/ImpossibleInstanceOfRuleTest.php
@@ -589,4 +589,16 @@ public function testReportAlwaysTrueInLastCondition(bool $reportAlwaysTrueInLast
 		$this->analyse([__DIR__ . '/data/impossible-instanceof-report-always-true-last-condition.php'], $expectedErrors);
 	}
 
+	public function testBug10201(): void
+	{
+		$this->checkAlwaysTrueInstanceOf = true;
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/../../Analyser/data/bug-10201.php'], [
+			[
+				'Instanceof between string and Bug10201\Hello will always evaluate to false.',
+				13,
+			],
+		]);
+	}
+
 }