more precise rule name and message

phpstan · Nov 21, 2023 · c405d44 · c405d44
1 parent 6e14549
commit c405d44
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/conf/config.level0.neon b/conf/config.level0.neon
@@ -82,7 +82,7 @@ rules:
 	- PHPStan\Rules\Keywords\ContinueBreakInLoopRule
 	- PHPStan\Rules\Methods\AbstractMethodInNonAbstractClassRule
 	- PHPStan\Rules\Methods\AbstractPrivateMethodRule
-	- PHPStan\Rules\Methods\AbstractProtectedMethodRule
+	- PHPStan\Rules\Methods\AbstractProtectedMethodInInterfaceRule
 	- PHPStan\Rules\Methods\CallMethodsRule
 	- PHPStan\Rules\Methods\CallStaticMethodsRule
 	- PHPStan\Rules\Methods\ConstructorReturnTypeRule

diff --git a/...s/Methods/AbstractProtectedMethodRule.php → ...bstractProtectedMethodInInterfaceRule.php b/...s/Methods/AbstractProtectedMethodRule.php → ...bstractProtectedMethodInInterfaceRule.php
@@ -10,7 +10,7 @@
 use function sprintf;
 
 /** @implements Rule<InClassMethodNode> */
-class AbstractProtectedMethodRule implements Rule
+class AbstractProtectedMethodInInterfaceRule implements Rule
 {
 
 	public function getNodeType(): string
@@ -41,7 +41,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		return [
 			RuleErrorBuilder::message(sprintf(
-				'Protected method %s::%s() cannot be abstract.',
+				'Protected method %s::%s() cannot be abstract in interface.',
 				$method->getDeclaringClass()->getDisplayName(),
 				$method->getName(),
 			))->nonIgnorable()->build(),

diff --git a/...thods/AbstractProtectedMethodRuleTest.php → ...actProtectedMethodInInterfaceRuleTest.php b/...thods/AbstractProtectedMethodRuleTest.php → ...actProtectedMethodInInterfaceRuleTest.php
@@ -5,20 +5,20 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 
-/** @extends RuleTestCase<AbstractProtectedMethodRule> */
-class AbstractProtectedMethodRuleTest extends RuleTestCase
+/** @extends RuleTestCase<AbstractProtectedMethodInInterfaceRule> */
+class AbstractProtectedMethodInInterfaceRuleTest extends RuleTestCase
 {
 
 	protected function getRule(): Rule
 	{
-		return new AbstractProtectedMethodRule();
+		return new AbstractProtectedMethodInInterfaceRule();
 	}
 
 	public function testRule(): void
 	{
 		$this->analyse([__DIR__ . '/data/abstract-methods.php'], [
 			[
-				'Protected method AbstractMethods\fooInterface::sayProtected() cannot be abstract.',
+				'Protected method AbstractMethods\fooInterface::sayProtected() cannot be abstract in interface.',
 				25,
 			],
 		]);