Fix inferring template types on intersection types

[rvanvelzen]

c877ec1 was incorrect in hindsight

Closes phpstan/phpstan#6904 and phpstan/phpstan#6917

[staabm]

as I noticed by coincidence - it doesn't need to be part of/fixed by this PR, but maybe its a related issue: phpstan/phpstan#5592 (comment)

just want to make you aware

[VincentLanglet]

Thanks for your quick reaction

[ondrejmirtes]

The failures in CI are in Rector and Composer:

Composer (https://github.com/composer/composer/blob/3ae111140facdba8ae82adcd1085e4adfc7d715c/src/Composer/Command/RemoveCommand.php#L181-L189)

 ------ ----------------------------------------------------------------------- 
  Line   src/Composer/Command/RemoveCommand.php                                 
 ------ ----------------------------------------------------------------------- 
  181    Only booleans are allowed in &&, array<string|Stringable> given on     
         the right side.                                                        
  181    Parameter #2 $array of static method Composer\Pcre\Preg::grep()        
         expects array<string|Stringable>, array<int, int|string> given.        
  181    Unable to resolve the template type T in call to method static method  
         Composer\Pcre\Preg::grep()                                             
         💡 See:                                                                
         https://phpstan.org/blog/solving-phpstan-error-unable-to-resolve-temp  
         late-type                                                              
  189    Only booleans are allowed in &&, array<string|Stringable> given on     
         the right side.                                                        
  189    Parameter #2 $array of static method Composer\Pcre\Preg::grep()        
         expects array<string|Stringable>, array<int, int|string> given.        
  189    Unable to resolve the template type T in call to method static method  
         Composer\Pcre\Preg::grep()                                             
         💡 See:                                                                
         https://phpstan.org/blog/solving-phpstan-error-unable-to-resolve-temp  
         late-type                                                              
 ------ ----------------------------------------------------------------------- 

Rector (https://github.com/rectorphp/rector-src/blob/303ecc342da1484619c4f875ad67850feeb4b52b/rules/Php80/Rector/ClassMethod/OptionalParametersAfterRequiredRector.php#L146)

 ------ ----------------------------------------------------------------------- 
  Line   rules/Php80/Rector/ClassMethod/OptionalParametersAfterRequiredRector.  
         php                                                                    
 ------ ----------------------------------------------------------------------- 
  146    Property PhpParser\Node\Expr\New_::$args                               
         (array<PhpParser\Node\Arg|PhpParser\Node\VariadicPlaceholder>) does    
         not accept array<PhpParser\Node\Arg|PhpParser\Node\Param>.             
  146    Unable to resolve the template type T in call to method                
         Rector\Php80\NodeResolver\ArgumentSorter::sortArgsByExpectedParamOrde  
         r()                                                                    
         💡 See:                                                                
         https://phpstan.org/blog/solving-phpstan-error-unable-to-resolve-temp  
         late-type                                                              
  164    Unable to resolve the template type T in call to method                
         Rector\Php80\NodeResolver\ArgumentSorter::sortArgsByExpectedParamOrde  
         r()                                                                    
         💡 See:                                                                
         https://phpstan.org/blog/solving-phpstan-error-unable-to-resolve-temp  
         late-type                                                              
  173    Property PhpParser\Node\Expr\MethodCall::$args                         
         (array<PhpParser\Node\Arg|PhpParser\Node\VariadicPlaceholder>) does    
         not accept array<PhpParser\Node\Arg|PhpParser\Node\Param>.             
 ------ ----------------------------------------------------------------------- 

[ondrejmirtes]

Can you please check what's going on in these errors and whether they are legit or whether they should be fixed in this PR? Feel free to reproduce them in phpstan-src test suite.

[rvanvelzen]

The composer failure seems legit to me: https://phpstan.org/r/33fa6126-1af3-49b2-b505-922f22367f11

[ondrejmirtes]

Thank you, awesome 😊

[rvanvelzen]

I was just about to say that the Rector one is a regression. Will send a PR once I've got a solution

[ondrejmirtes]

It's fine, I'm not releasing it right away 😊 Thank you.

[rvanvelzen]

Perhaps I was wrong. This seems to be the Rector case: https://phpstan.org/r/ca5584c3-6a43-4046-b1d2-b7514b9e699a

Before array<First|Second> would be resolved as array<Second> when passed to T of array<Second|Third>, but that no longer happens and you now get the error about incompatible types.

So if you agree I'll leave this as-is, and we'll hear about actual regressions when this is released.

[ondrejmirtes]

Alright, I'm gonna tag 1.5.1 :)