Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test #1749

Merged
merged 3 commits into from Oct 2, 2022
Merged

Regression test #1749

merged 3 commits into from Oct 2, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 23, 2022 •
edited

@staabm staabm marked this pull request as ready for review September 23, 2022 13:27
ondrejmirtes
ondrejmirtes requested changes Oct 2, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't fail when the fix is reverted. You can't test "Parameter #1 $boolAbilities of class HelloWorld constructor expects" in TypesAssignedToPropertiesRuleTest.

@staabm staabm force-pushed the regress7594 branch 2 times, most recently from 2f801be to 2d8a8aa Compare October 2, 2022 16:13
@ondrejmirtes ondrejmirtes changed the title added regression test Regression test Oct 2, 2022
@ondrejmirtes ondrejmirtes merged commit fc0f990 into phpstan:1.8.x Oct 2, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the regress7594 branch October 2, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@staabm @ondrejmirtes @clxmstaab