Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more integer range vs. int constants tests #1750

Merged
merged 2 commits into from Oct 5, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 23, 2022

@staabm staabm marked this pull request as ready for review September 23, 2022 13:43
@staabm staabm force-pushed the int-range branch 2 times, most recently from bec7834 to 3569e2f Compare October 3, 2022 18:57
@ondrejmirtes
Copy link
Member

Thank you! BTW Why do you have two GitHub accounts used seemingly randomly? 🤔

@ondrejmirtes ondrejmirtes merged commit 71878a6 into phpstan:1.8.x Oct 5, 2022
@staabm staabm deleted the int-range branch October 5, 2022 15:34
@staabm
Copy link
Contributor Author

staabm commented Oct 5, 2022

I have one account for private stuff (configured on my personal computer) and another account for company stuff (which is configured on a different computer).

Depending on where I currently work, I can commit stuff into each others PR

:-)

@ondrejmirtes
Copy link
Member

A tip: Use .git/config in your local clone of phpstan-src to unify this for PHPStan :)

@herndlm
Copy link
Contributor

herndlm commented Oct 5, 2022

Yeah I was wondering the same thing already :) btw I also use two computers where I git config my private email into one for phpstan because the global one is my work email

@mad-briller
Copy link
Contributor

i think my first commit to phpstan was with my work email not my github one, but it was already merged before i realized 😅

you can set it with git config user.name <name> and git config user.email <email>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants