Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreErrors fix #1769

Merged
merged 1 commit into from Sep 28, 2022
Merged

Conversation

MartinMystikJonas
Copy link
Contributor

This is fix for my extension of ignoreErrors. I found out it does not work as expected when I used it in real-world project. This should fix it and I added test to cover it.

@ondrejmirtes
Copy link
Member

Can you explain to me in text why do you make this change and what is your expectation?

@MartinMystikJonas
Copy link
Contributor Author

MartinMystikJonas commented Sep 28, 2022

  1. ValidateIgnoredErrorsExtension was failing to validate entries with multiple messages. I extended it and I have to extract part of code to method to prevent too deep nesting.
  2. Config schema did, not allowed use of reportUnmatched without path/paths so I modified it.

@ondrejmirtes ondrejmirtes merged commit f9bb961 into phpstan:1.8.x Sep 28, 2022
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants