Make array access tolerant with isset

.github/workflows/apiref.yml

@@ -3,6 +3,7 @@
 name: "API Reference"
 
 on:
+  workflow_dispatch:
   push:
     branches:
       - "1.9.x"

.github/workflows/backward-compatibility.yml

@@ -6,13 +6,13 @@ on:
   pull_request:
   push:
     branches:
-      - "1.8.x"
+      - "1.9.x"
     paths:
       - 'src/**'
       - '.github/workflows/backward-compatibility.yml'
 
 env:
-  COMPOSER_ROOT_VERSION: "1.8.x-dev"
+  COMPOSER_ROOT_VERSION: "1.9.x-dev"
 
 concurrency:
   group: bc-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches

.github/workflows/changelog-generator.yml

@@ -9,7 +9,7 @@ on:
       - '.github/workflows/changelog-generator.yml'
   push:
     branches:
-      - "1.8.x"
+      - "1.9.x"
     paths:
       - 'changelog-generator/**'
       - '.github/workflows/changelog-generator.yml'

.github/workflows/e2e-tests.yml

@@ -10,14 +10,14 @@ on:
       - 'changelog-generator/**'
   push:
     branches:
-      - "1.8.x"
+      - "1.9.x"
     paths-ignore:
       - 'compiler/**'
       - 'apigen/**'
       - 'changelog-generator/**'
 
 env:
-  COMPOSER_ROOT_VERSION: "1.8.x-dev"
+  COMPOSER_ROOT_VERSION: "1.9.x-dev"
 
 concurrency:
   group: e2e-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches

.github/workflows/lint.yml

@@ -6,10 +6,10 @@ on:
   pull_request:
   push:
     branches:
-      - "1.8.x"
+      - "1.9.x"
 
 env:
-  COMPOSER_ROOT_VERSION: "1.8.x-dev"
+  COMPOSER_ROOT_VERSION: "1.9.x-dev"
 
 concurrency:
   group: lint-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches

.github/workflows/phar.yml

@@ -6,9 +6,9 @@ on:
   pull_request:
   push:
     branches:
-      - "1.8.x"
+      - "1.9.x"
     tags:
-      - '1.8.*'
+      - '1.9.*'
 
 concurrency:
   group: phar-${{ github.ref }} # will be canceled on subsequent pushes in both branches and pull requests
@@ -90,14 +90,14 @@ jobs:
       - name: "Composer dump"
         run: "composer install --no-interaction --no-progress"
         env:
-          COMPOSER_ROOT_VERSION: "1.8.x-dev"
+          COMPOSER_ROOT_VERSION: "1.9.x-dev"
 
       - name: "Compile PHAR for checksum"
         working-directory: "compiler/build"
         run: "php box.phar compile --no-parallel"
         env:
           PHAR_CHECKSUM: "1"
-          COMPOSER_ROOT_VERSION: "1.8.x-dev"
+          COMPOSER_ROOT_VERSION: "1.9.x-dev"
 
       - name: "Re-sign PHAR"
         run: "php compiler/build/resign.php tmp/phpstan.phar"
@@ -120,30 +120,30 @@ jobs:
   integration-tests:
     if: github.event_name == 'pull_request'
     needs: compiler-tests
-    uses: phpstan/phpstan/.github/workflows/integration-tests.yml@1.8.x
+    uses: phpstan/phpstan/.github/workflows/integration-tests.yml@1.9.x
     with:
-      ref: 1.8.x
+      ref: 1.9.x
       phar-checksum: ${{needs.compiler-tests.outputs.checksum}}
 
   extension-tests:
     if: github.event_name == 'pull_request'
     needs: compiler-tests
-    uses: phpstan/phpstan/.github/workflows/extension-tests.yml@1.8.x
+    uses: phpstan/phpstan/.github/workflows/extension-tests.yml@1.9.x
     with:
-      ref: 1.8.x
+      ref: 1.9.x
       phar-checksum: ${{needs.compiler-tests.outputs.checksum}}
 
   other-tests:
     if: github.event_name == 'pull_request'
     needs: compiler-tests
-    uses: phpstan/phpstan/.github/workflows/other-tests.yml@1.8.x
+    uses: phpstan/phpstan/.github/workflows/other-tests.yml@1.9.x
     with:
-      ref: 1.8.x
+      ref: 1.9.x
       phar-checksum: ${{needs.compiler-tests.outputs.checksum}}
 
   commit:
     name: "Commit PHAR"
-    if: "github.repository_owner == 'phpstan' && (github.ref == 'refs/heads/1.8.x' || startsWith(github.ref, 'refs/tags/'))"
+    if: "github.repository_owner == 'phpstan' && (github.ref == 'refs/heads/1.9.x' || startsWith(github.ref, 'refs/tags/'))"
     needs: compiler-tests
     runs-on: "ubuntu-latest"
     timeout-minutes: 60
@@ -159,7 +159,7 @@ jobs:
           repository: phpstan/phpstan
           path: phpstan-dist
           token: ${{ secrets.PAT }}
-          ref: 1.8.x
+          ref: 1.9.x
 
       - name: "Get previous pushed dist commit"
         id: previous-commit

.github/workflows/static-analysis.yml

@@ -10,14 +10,14 @@ on:
       - 'changelog-generator/**'
   push:
     branches:
-      - "1.8.x"
+      - "1.9.x"
     paths-ignore:
       - 'compiler/**'
       - 'apigen/**'
       - 'changelog-generator/**'
 
 env:
-  COMPOSER_ROOT_VERSION: "1.8.x-dev"
+  COMPOSER_ROOT_VERSION: "1.9.x-dev"
 
 concurrency:
   group: sa-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches

.github/workflows/tests.yml

@@ -10,14 +10,14 @@ on:
       - 'changelog-generator/**'
   push:
     branches:
-      - "1.8.x"
+      - "1.9.x"
     paths-ignore:
       - 'compiler/**'
       - 'apigen/**'
       - 'changelog-generator/**'
 
 env:
-  COMPOSER_ROOT_VERSION: "1.8.x-dev"
+  COMPOSER_ROOT_VERSION: "1.9.x-dev"
 
 concurrency:
   group: tests-${{ github.head_ref || github.run_id }} # will be canceled on subsequent pushes in pull requests but not branches

build/phpstan.neon

@@ -103,19 +103,3 @@ services:
 		class: PHPStan\Internal\ContainerDynamicReturnTypeExtension
 		tags:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
-
-	scopeIsInClass:
-		class: PHPStan\Internal\ScopeIsInClassTypeSpecifyingExtension
-		arguments:
-			isInMethodName: isInClass
-			removeNullMethodName: getClassReflection
-		tags:
-			- phpstan.typeSpecifier.methodTypeSpecifyingExtension
-
-	scopeIsInTrait:
-		class: PHPStan\Internal\ScopeIsInClassTypeSpecifyingExtension
-		arguments:
-			isInMethodName: isInTrait
-			removeNullMethodName: getTraitReflection
-		tags:
-			- phpstan.typeSpecifier.methodTypeSpecifyingExtension

conf/bleedingEdge.neon

@@ -19,3 +19,4 @@ parameters:
 		runtimeReflectionRules: true
 		notAnalysedTrait: true
 		curlSetOptTypes: true
+		listType: true

conf/config.level2.neon

@@ -33,6 +33,8 @@ rules:
 	- PHPStan\Rules\Operators\InvalidComparisonOperationRule
 	- PHPStan\Rules\PhpDoc\FunctionConditionalReturnTypeRule
 	- PHPStan\Rules\PhpDoc\MethodConditionalReturnTypeRule
+	- PHPStan\Rules\PhpDoc\FunctionAssertRule
+	- PHPStan\Rules\PhpDoc\MethodAssertRule
 	- PHPStan\Rules\PhpDoc\IncompatibleClassConstantPhpDocTypeRule
 	- PHPStan\Rules\PhpDoc\IncompatiblePhpDocTypeRule
 	- PHPStan\Rules\PhpDoc\IncompatiblePropertyPhpDocTypeRule

conf/config.neon

@@ -49,6 +49,7 @@ parameters:
 		runtimeReflectionRules: false
 		notAnalysedTrait: false
 		curlSetOptTypes: false
+		listType: false
 	fileExtensions:
 		- php
 	checkAdvancedIsset: false
@@ -136,6 +137,7 @@ parameters:
 		- ../stubs/Exception.stub
 		- ../stubs/arrayFunctions.stub
 		- ../stubs/core.stub
+		- ../stubs/typeCheckingFunctions.stub
 	earlyTerminatingMethodCalls: []
 	earlyTerminatingFunctionCalls: []
 	memoryLimitFile: %tmpDir%/.memory_limit
@@ -256,6 +258,7 @@ parametersSchema:
 		runtimeReflectionRules: bool()
 		notAnalysedTrait: bool()
 		curlSetOptTypes: bool()
+		listType: bool()
 	])
 	fileExtensions: listOf(string())
 	checkAdvancedIsset: bool()
@@ -1015,6 +1018,9 @@ services:
 	-
 		class: PHPStan\Rules\PhpDoc\ConditionalReturnTypeRuleHelper
 
+	-
+		class: PHPStan\Rules\PhpDoc\AssertRuleHelper
+
 	-
 		class: PHPStan\Rules\PhpDoc\UnresolvableTypeHelper
 
@@ -1648,11 +1654,6 @@ services:
 		tags:
 			- phpstan.typeSpecifier.functionTypeSpecifyingExtension
 
-	-
-		class: PHPStan\Type\Php\IsStringFunctionTypeSpecifyingExtension
-		tags:
-			- phpstan.typeSpecifier.functionTypeSpecifyingExtension
-
 	-
 		class: PHPStan\Type\Php\IsSubclassOfFunctionTypeSpecifyingExtension
 		tags: