Improve array_search type specifier performance

[rvanvelzen]

Mostly resolves phpstan/phpstan#8147. The added integration test case went down from a ~minute to ~10 seconds locally.

[herndlm]

haha, nice one

[ondrejmirtes]

Something's fishy here. Without the change in src, the test on my machine runs in 6 seconds. With the change, it runs in less than 2 seconds.

$ vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php --filter testBug8147
PHPUnit 9.5.23 #StandWithUkraine

Warning:       No code coverage driver available

.                                                                   1 / 1 (100%)

Time: 00:01.874, Memory: 76.00 MB

OK (1 test, 1 assertion)

Sure, 3x improvement is nice, but the numbers are nowhere near "~minute to ~10 seconds".

Maybe something change meanwhile that also optimized this?

[ondrejmirtes]

Thank you.

[rvanvelzen]

I did reduce the test case a bit afterwards, which obviously reduces the runtime a bit. My machine was also quite busy which could have skewed the numbers a bit.

[ondrejmirtes]

Makes sense 😊