Promote native types #1943
Promote native types #1943
Conversation
|
/cc @rajyan I feel like we need these fixes but judging from the results in the pipeline it's too soon for them and we need other fixes before that :) |
ondrejmirtes
force-pushed
the
promote-native-types
branch
5 times, most recently
from
d583dc7 to
c5f39aa
Compare
|
I checked not sure enough with nextras/orm The first failure of phpstan-phpunit is wrong. |
|
Looks like we are almost there! |
|
Some of the existing errors are because getNativeType() for MethodCall should only read native typehints. I'm already working on it locally 😊 And the todos in that issue will help with various little bugs... I think we can release 1.9.0 at any time and leave this for a future version, it's already feature-packed and 1.9.x branch is stable enough now 😊 Another problem in this PR is performance, calling TypeSpecifier twice slows PHPStan down, I'd love to see some ideas for optimizations. |
Looking forward for the release!!
Yeah, performance was one problem I was worried about when thinking about native types. |
ondrejmirtes
force-pushed
the
promote-native-types
branch
3 times, most recently
from
a574748 to
046cb23
Compare
ondrejmirtes
force-pushed
the
promote-native-types
branch
2 times, most recently
from
cdd450a to
e0e86b2
Compare
ondrejmirtes
force-pushed
the
promote-native-types
branch
from
e0e86b2 to
f8ec949
Compare
This reverts commit 461801bf601de63fc80eca8810324bd69e69d3b9.
ondrejmirtes
force-pushed
the
promote-native-types
branch
from
1e26bfb to
6652811
Compare
Closes phpstan/phpstan#4689 Closes phpstan/phpstan#7578 Closes phpstan/phpstan#6260
|
It's not perfect but it's fine :) |
|
This pull request has been marked as ready for review. |
|
I'm glad to know and thank you for improving the Native types idea to a level where it can be merged! |
No description provided.