handle ClassConstFetch in scope #1944
Merged
+233
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's obvious that |
|
This pull request has been marked as ready for review. |
rajyan
commented
Oct 31, 2022
Comment on lines
+7
to
+51
| class HelloWorld | ||
| { | ||
| public static function doFoo() | ||
| { | ||
| if (defined('Foo::TEST')) { | ||
| Foo::TEST; | ||
| \Foo::TEST; | ||
| \ClassConstFetchDefined\Foo::TEST; | ||
| } else { | ||
| Foo::TEST; | ||
| \Foo::TEST; | ||
| \ClassConstFetchDefined\Foo::TEST; | ||
| } | ||
|
|
||
| if (defined('\Foo::TEST')) { | ||
| Foo::TEST; | ||
| \Foo::TEST; | ||
| \ClassConstFetchDefined\Foo::TEST; | ||
| } else { | ||
| Foo::TEST; | ||
| \Foo::TEST; | ||
| \ClassConstFetchDefined\Foo::TEST; | ||
| } | ||
|
|
||
| if (defined('ClassConstFetchDefined\Foo::TEST')) { | ||
| Foo::TEST; | ||
| \Foo::TEST; | ||
| \ClassConstFetchDefined\Foo::TEST; | ||
| } else { | ||
| Foo::TEST; | ||
| \Foo::TEST; | ||
| \ClassConstFetchDefined\Foo::TEST; | ||
| } | ||
|
|
||
| if (defined('\ClassConstFetchDefined\Foo::TEST')) { | ||
| Foo::TEST; | ||
| \Foo::TEST; | ||
| \ClassConstFetchDefined\Foo::TEST; | ||
| } else { | ||
| Foo::TEST; | ||
| \Foo::TEST; | ||
| \ClassConstFetchDefined\Foo::TEST; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
verified the behavior by https://3v4l.org/ueJTH
rajyan
commented
Oct 31, 2022
| && !$context->null(); | ||
| && $context->truthy(); |
There was a problem hiding this comment.
Not exist !== NeverType so I think this makes things better.
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#8034
blocking
phpstan/phpstan#8191
regression from
#1938
Steps to fix