Skip to content

Faster ConstantFloatType->isSuperTypeOf(ConstantFloatType) #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 11, 2022

40% speedup of phpstan/phpstan#8504

This file mmarton/phpstan-issue8146@master/src/DataFixtures/LocationFixtures.php from phpstan/phpstan#8146 really slows PHPStan down, because it contains a lot of literal arrays.


grafik

@staabm staabm marked this pull request as ready for review December 11, 2022 12:02
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@staabm staabm force-pushed the float-fast-compare branch from 115cd3f to c257845 Compare December 11, 2022 12:07
@ondrejmirtes ondrejmirtes merged commit 94c841a into phpstan:1.9.x Dec 11, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the float-fast-compare branch December 11, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants