Implement php version dependent loose const comparison #2220
+178
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
loose-constants
branch
from
303b0ce to
869c9fa
Compare
staabm
force-pushed
the
loose-constants
branch
3 times, most recently
from
48fb829 to
81386b6
Compare
staabm
commented
Feb 5, 2023
staabm
force-pushed
the
loose-constants
branch
2 times, most recently
from
0c903fc to
af13974
Compare
ondrejmirtes
requested changes
Feb 6, 2023
staabm
force-pushed
the
loose-constants
branch
from
3772b73 to
73502ed
Compare
clxmstaab
force-pushed
the
loose-constants
branch
from
73502ed to
39766bf
Compare
staabm
force-pushed
the
loose-constants
branch
from
39766bf to
9d51998
Compare
|
This pull request has been marked as ready for review. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #2216 (comment)
see https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.core.string-number-comparision
https://3v4l.org/pWAjV
https://3v4l.org/0VWtq
https://phpstan.org/r/b2748c38-b33e-4db7-a60f-4f5edd991270