Preparational refactoring to ease implementation of Type->looseCompare(type, phpVersion)
#2225
+286
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clxmstaab
force-pushed
the
refactor-loose
branch
from
71f4c99 to
dceaf8e
Compare
staabm
commented
Feb 6, 2023
clxmstaab
force-pushed
the
refactor-loose
branch
from
dceaf8e to
5c3373a
Compare
…re(type, phpVersion)`
clxmstaab
force-pushed
the
refactor-loose
branch
from
5c3373a to
1f5585b
Compare
|
This pull request has been marked as ready for review. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets see whether we agree on this intermediate step