-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3 leading spaces in PHAR #2254
Conversation
@ondrejmirtes I must be blind but I don't see the artifact. |
in the "compile phar" action at the bottom https://github.com/phpstan/phpstan-src/actions/runs/4260429654 sorry for the huge screenshots 😅 |
@staabm Thanks! |
This pull request has been marked as ready for review. |
When PHP-CS-Fixer is present in the project, what about invoking it and keeping the phpstan PHP file CS always fixed? |
Feels like a waste of resources especially on large baselines with 15k lines. PHP CS Fixer is not the fastest.... I will fix the CS in this PR so that we can merge the actual fix. |
Fixes phpstan/phpstan#8952 I think the problem comes from the nowdoc related to Box/Rector.
Ideally, all files should end with a newline
@ondrejmirtes CS is fixed. And I verified that the new PHAR generates the baseline correctly. |
Thank you! |
Fixes phpstan/phpstan#8952
I think the problem comes from the nowdoc related to Box/Rector.