Use bottom type for read/write-only properties #2328
Merged
+75
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… readable types separately
jtojnar
force-pushed
the
never-incorrect-type
branch
from
6acb312 to
880dc47
Compare
ondrejmirtes
requested changes
Apr 5, 2023
…ad/write-only properties It is not meaningful to return the writable type from getReadableType() type for non-readable properties. Let’s return a bottom type to make it clear that no value can be read from the property. And similarly, for non-writable properties, getReadableType() will return bottom type to emphasize that no value exists that can be written to the property.
jtojnar
force-pushed
the
never-incorrect-type
branch
from
880dc47 to
8ebee0b
Compare
|
Done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2327
It is not meaningful to return the writable type from getReadableType() type for non-readable properties.
Let’s return a bottom type to make it clear that no value can be read from the property.
And similarly, for non-writable properties, getReadableType() will return bottom type
to emphasize that no value exists that can be written to the property.
Probably best rebase-merge so that the second commit can be easily reverted if it turns out it causes too many issues.