Add return type extension for constant()
#2474
Merged
+136
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
herndlm
force-pushed
the
constant
branch
4 times, most recently
from
a99340f to
ba461b2
Compare
staabm
reviewed
Jun 21, 2023
| assertType('mixed', constant($constantName)); | ||
| } | ||
|
|
||
| assertType("'foo'", FOO); |
There was a problem hiding this comment.
Can the asserts be moved into a function or method?
There was a problem hiding this comment.
sure, but not sure if they really hurt here :)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had that idea when phpstan/phpstan#9295 was created.
See https://www.php.net/manual/en/function.constant.php and https://3v4l.org/66no7
UPDATE: prior to PHP 8 it would trigger a warning for inexistent constants and return
null. But not sure if it's worth the effort to implement this. right now it would just return*ERROR*for such cases. UPDATE2: this feels related to also support non-existing constants as expressions, so I'll refrain from adding any code for it for now. E.g. https://3v4l.org/FTHPv / https://phpstan.org/r/c649b7bb-8031-4210-9c4b-c469eba63d3b