fix: mark Ds\Queue::pop() as impure

[simPod]

Resolves #9682

[phpstan-bot]

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

[ondrejmirtes]

Can you please check other similar methods that might have the same problem? The key is that the method returns a value AND changes the underlying collection.

Such an example: Stack::pop()

If it does not return a value (it's void) then such a method is already understood as impure by PHPStan.

[simPod]

I tried to mark all eligible I know of.

[ondrejmirtes]

I don't think that first/last and peek are impure.

[simPod]

ok i missed "changes" in The key is that the method returns a value AND changes the underlying collection.

[ondrejmirtes]

Thank you.