Fix ftp related function signatures #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please remove this change. There's no need to change the name. |
1) The 'mode' parameter became optional as of PHP 7.3.0 2) Function 'ftp_nb_get()' returns 'int|false'
thg2k
force-pushed
the
pr/ftp_functions_signatures
branch
from
9de74c5
to
12a2f18
Compare
|
I removed the change of the parameter name. Although i don't understand why it should stay inconsistent across the same family of functions. Also rebased to current 1.10.x |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
Consistent naming of the first parameter 'stream' (it should actually be 'ftp' since 8.x, but then it should be changed in the delta file)(removed per maintainer request)