Infer object type mysqli_fetch_object #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
commented
Oct 12, 2023
resources/functionMap.php
Outdated
| @@ -7472,7 +7472,7 @@ | |||
| 'mysqli_fetch_field_direct' => ['object|false', 'result'=>'mysqli_result', 'fieldnr'=>'int'], | |||
| 'mysqli_fetch_fields' => ['array', 'result'=>'mysqli_result'], | |||
| 'mysqli_fetch_lengths' => ['array|false', 'result'=>'mysqli_result'], | |||
| 'mysqli_fetch_object' => ['object|null', 'result'=>'mysqli_result', 'class_name='=>'string', 'params='=>'?array'], | |||
| 'mysqli_fetch_object' => ['object|false|null', 'result'=>'mysqli_result', 'class_name='=>'class-string', 'params='=>'?array'], | |||
There was a problem hiding this comment.
seem we were missing the possible false type in php 7.2/7.3.
in newer versions it was already valid because of php8-stubs
There was a problem hiding this comment.
Don’t sneak in narrower parameter types like this 😊
There was a problem hiding this comment.
ahh good point. just dropped the param type change
ondrejmirtes
requested changes
Oct 12, 2023
resources/functionMap.php
Outdated
| @@ -7472,7 +7472,7 @@ | |||
| 'mysqli_fetch_field_direct' => ['object|false', 'result'=>'mysqli_result', 'fieldnr'=>'int'], | |||
| 'mysqli_fetch_fields' => ['array', 'result'=>'mysqli_result'], | |||
| 'mysqli_fetch_lengths' => ['array|false', 'result'=>'mysqli_result'], | |||
| 'mysqli_fetch_object' => ['object|null', 'result'=>'mysqli_result', 'class_name='=>'string', 'params='=>'?array'], | |||
| 'mysqli_fetch_object' => ['object|false|null', 'result'=>'mysqli_result', 'class_name='=>'class-string', 'params='=>'?array'], | |||
There was a problem hiding this comment.
Don’t sneak in narrower parameter types like this 😊
|
fixed conflicts |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.