Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix !isset() with Variable #2710

Merged
merged 37 commits into from
Nov 28, 2023
Merged

Fix !isset() with Variable #2710

merged 37 commits into from
Nov 28, 2023

Commits on Nov 28, 2023

  1. Regression test

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1ac5e19 View commit details
    Browse the repository at this point in the history

  2. Fix variable certainty for ArrayDimFetch in falsey isset context

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c75d892 View commit details
    Browse the repository at this point in the history

  3. More precise falsey isset()

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    28592a9 View commit details
    Browse the repository at this point in the history

  4. Rewrite multi-arg isset() to BooleanAnd chain

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f3106f3 View commit details
    Browse the repository at this point in the history

  5. Improve dependent type inference in truthy BooleanOr and falsy Boolea… 

    …nAnd conditions
    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ccb4f63 View commit details
    Browse the repository at this point in the history

  6. Fix build

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    fe30fd5 View commit details
    Browse the repository at this point in the history

  7. Fix conditional expressions when assigning a ternary operator

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    96c909a View commit details
    Browse the repository at this point in the history

  8. Make it work for short ternaries too

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    41357e5 View commit details
    Browse the repository at this point in the history

  9. Fix conditional expressions logic

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    04d44ab View commit details
    Browse the repository at this point in the history

  10. Fix !isset() with Variable

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b9acee8 View commit details
    Browse the repository at this point in the history

  11. more tests

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    442f047 View commit details
    Browse the repository at this point in the history

  12. mixed tests

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2046db0 View commit details
    Browse the repository at this point in the history

  13. simplify?

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f99e6d3 View commit details
    Browse the repository at this point in the history

  14. more tests

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    850eb15 View commit details
    Browse the repository at this point in the history

  15. refactor

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3809fc9 View commit details
    Browse the repository at this point in the history

  16. remove unnecessary unset()

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    cd1fc73 View commit details
    Browse the repository at this point in the history

  17. More tests

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    762e6a6 View commit details
    Browse the repository at this point in the history

  18. more tests, fixes

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a9cab71 View commit details
    Browse the repository at this point in the history

  19. added drupal test

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e497572 View commit details
    Browse the repository at this point in the history

  20. Revert "added drupal test" 

    This reverts commit 3eda7cc.
    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f86dbe3 View commit details
    Browse the repository at this point in the history

  21. relax test

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    20be372 View commit details
    Browse the repository at this point in the history

  22. added failling coalesce test

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    dd9a745 View commit details
    Browse the repository at this point in the history

  23. experimental coalesce fix

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    77389f0 View commit details
    Browse the repository at this point in the history

  24. added ternary certainty tests

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7be4cff View commit details
    Browse the repository at this point in the history

  25. test isset()/empty() with unset()

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    9c082f0 View commit details
    Browse the repository at this point in the history

  26. restore certainty in ternary isset()

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    91f2532 View commit details
    Browse the repository at this point in the history

  27. fix conditional types after ternary, when types overlap

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d0dede2 View commit details
    Browse the repository at this point in the history

  28. more reverse ternary tests

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5e8c3b8 View commit details
    Browse the repository at this point in the history

  29. assert more types

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    20e5054 View commit details
    Browse the repository at this point in the history

  30. simplify

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a01cb4c View commit details
    Browse the repository at this point in the history

  31. Fix certainty of by-ref variables in ternary condition

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a917377 View commit details
    Browse the repository at this point in the history

  32. lazier type resolving

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7bcda04 View commit details
    Browse the repository at this point in the history

  33. Fix conditional types

    @staabm @ondrejmirtes
    staabm authored and ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4bab4bb View commit details
    Browse the repository at this point in the history

  34. Fix conditional bug

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b9948f5 View commit details
    Browse the repository at this point in the history

  35. added regression test for conditional bug 

    fix was in phpstan@b9948f5
    @staabm
    staabm committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    32cbe96 View commit details
    Browse the repository at this point in the history

  36. Restore original Ternary handling

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6e72a32 View commit details
    Browse the repository at this point in the history

  37. Fix ternary scope merging for always-true and always-false condition

    @ondrejmirtes
    ondrejmirtes committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e718636 View commit details
    Browse the repository at this point in the history