add named arguments variants to reflection golden test #2743
+20
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
schlndh
deleted the
feature-addNamedArgumentsVariantsToReflectionGoldenTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding the named arguments variants to the reflection golden test as promised. I added a condition to exclude some cases where the names in the function map are already correct. There are some more duplicates due to the parameter names in the positional variant being fixed later via phpstorm stubs.
I also found that the phpstorm stubs are sometimes incorrect (at least
XSLTProcessor::setParameterandPDOStatement::setFetchMode). So I'd remove the rename for named params in next PR.