remove fake params from setcookie/setrawcookie #2752
Merged
+66
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#10171
It turns out that this is wrong: #152 When I try to call
setcookie
with all 9 parameters it says that max 7 are accepted (PHP 8.2), named arguments such assamesite: 'lax'
also don't work. I'm guessing that the arguments in thephp_setcookie
C function are there to cover the different variants +setcookie
vssetrawcookie
, but I haven't checked it.https://3v4l.org/eN9lM