Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RedefinedParametersRule #2755

Merged
merged 1 commit into from Nov 21, 2023
Merged

Add RedefinedParametersRule #2755

merged 1 commit into from Nov 21, 2023

Conversation

paulbalandan
Copy link
Contributor

@ondrejmirtes ondrejmirtes merged commit b77f894 into phpstan:1.10.x Nov 21, 2023
425 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@ondrejmirtes
Copy link
Member

Did you please look into this?

Research what PHP version considers this as an error. I remember a situation that such code was present in a library (React.PHP maybe) and it started failing only on PHP 8.0 or so.

@ondrejmirtes ondrejmirtes mentioned this pull request Nov 21, 2023
Closed
@paulbalandan paulbalandan deleted the redefined-parameters branch November 21, 2023 05:56
@paulbalandan
Copy link
Contributor Author

Did you please look into this?

Research what PHP version considers this as an error. I remember a situation that such code was present in a library (React.PHP maybe) and it started failing only on PHP 8.0 or so.

I did not look really at reactphp. I just tried redefined parameters at 3v4l.org and changed the PHP version from 7.2 up. All are failing.

@ondrejmirtes
Copy link
Member

Alright 😊

@ondrejmirtes ondrejmirtes mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paulbalandan @ondrejmirtes