Test PHP-Parser 5 #2839
Draft
Test PHP-Parser 5 #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
ondrejmirtes
force-pushed
the
2.0.x
branch
4 times, most recently
from
3de9c78
to
431e57f
Compare
This was referenced Jan 1, 2024
…etween Name and Identifier
|
just a side-note: in roave/BetterReflection updating to PHP-Parser 5 yielded memory improvements. it might be worth measuring performance metrics when this PR is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is named 2.0.x because PHP-Parser will be supported in PHPStan 2.0. But the release of PHPStan 2.0 is months away and will be out some time in 2024.