fix spaceship operator for large constant unions #2886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false positive encountered by #2885 . I simplified it to smaller example: https://phpstan.org/r/892eed14-49b8-4a98-b591-90cf5741a99e
This scenario only happens with bleeding edge enabled. Without it the constant union doesn't make it into
getSpaceshipType
due tophpstan-src/src/Type/Generic/TemplateTypeTrait.php
Line 269 in 4e1bfac
As far as I can tell, the spaceship operator should always return -1, 0, or 1: https://3v4l.org/FVeq7