Constants deprecation depends on php version in comment #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clxmstaab
force-pushed
the
fail-test
branch
2 times, most recently
from
ae2841d
to
8623b12
Compare
|
This pull request has been marked as ready for review. |
staabm
commented
Mar 13, 2024
| // filter raw version number messages like in | ||
| // https://github.com/JetBrains/phpstorm-stubs/blob/9608c953230b08f07b703ecfe459cc58d5421437/filter/filter.php#L478 | ||
| if (Strings::match($deprecatedMessage ?? '', '#^\d+\.\d+(\.\d+)?$#') === null) { | ||
| $matches = Strings::match($deprecatedMessage ?? '', '#^(\d+)\.(\d+)(?:\.(\d+))?$#'); |
There was a problem hiding this comment.
this duplicates the logic which should already have happened in BetterReflection.. I think it is wrong
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since support for
@deprecatedon constants was added into BetterReflection with this PR we now take care of interpreting the phpdoc comment and decide per phpversion when a constant is deprecated or not.this also makes sure that the deprecation message depends on phpstan.neon
phpVersion.closes phpstan/phpstan#10700