Prevent unnecessary calls into reflection from JSON extensions #2994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In todays debugging session I realized that the json throw extensions call into reflection even for non
json_*
calls.accidentally spotted while working on Roave/BetterReflection#1415
move the cheaper check in front to prevent this unnecessary reflection stuff.
see
I looked arround for similar problems in other extensions but could not see additional ones.