Fail when offset on array does not exist #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttomdewit
force-pushed
the
undefined-array-offsets
branch
2 times, most recently
from
bb47faf
to
53bc5c2
Compare
|
This pull request has been marked as ready for review. |
Let PHPStan fail when possibly non-existing array offset is used. Fixes phpstan/phpstan#7553 All credits to https://github.com/ondrejmirtes Add initial step to fail when offset on an array does not exist.
ondrejmirtes
force-pushed
the
undefined-array-offsets
branch
from
53bc5c2
to
781cd5c
Compare
ondrejmirtes
force-pushed
the
undefined-array-offsets
branch
from
781cd5c
to
ff033e3
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial step to fail when offset on an array does not exist.
All credit to https://github.com/ondrejmirtes
Fixes phpstan/phpstan#7553