Fix 10922: array type in foreach

[VincentLanglet]

Closes phpstan/phpstan#10922

[VincentLanglet]

I'm not sure about the purpose of

if ($this->polluteScopeWithAlwaysIterableForeach) {
     $finalScope = $finalScope->mergeWith($scope->filterByTruthyValue(new BooleanOr(
	     new BinaryOp\Identical(
		     $stmt->expr,
			 new Array_([]),
	     ),
		 new FuncCall(new Name\FullyQualified('is_object'), [
			 new Arg($stmt->expr),
		 ]),
	)));
} else {
	$finalScope = $finalScope->mergeWith($scope);
}

But I soon as I make this change, the issue is solved.

I dunno

• if it has a bad impact (I can add tests if you had some in mind)
• if I should just remove the else part and the if condition.

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Merging with parent would be better (I think bleedingEdge is there already)

[VincentLanglet]

Parent is

/**
	 * @return string[]
	 */
	public static function getAdditionalConfigFiles(): array
	{
		return [];
	}

[VincentLanglet]

NodeScopeResolverTest use

	public static function getAdditionalConfigFiles(): array
	{
		return [
			__DIR__ . '/../../../conf/bleedingEdge.neon',
			__DIR__ . '/typeAliases.neon',
		];
	}

I followed the same idea

[ondrejmirtes]

Thank you.