ExponentiateHelper: fix internal error and internal warning #3031
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Apr 25, 2024
| $result = $base->getValue() ** $exponent->getValue(); | ||
| try { | ||
| // @ to avoid "Warning: A non-numeric value encountered" | ||
| $result = @pow($base->getValue(), $exponent->getValue()); // @phpstan-ignore-line |
There was a problem hiding this comment.
I'd rather prevent the problem by checking the type of the values instead of silencing the error.
There was a problem hiding this comment.
That would require some crazy regexes. I dont think there is a simple way to simulate the magical numeric-string behaviour: https://3v4l.org/ECZjp#v8.3.6
This way we are sure we get exactly what PHP evalutes.
There was a problem hiding this comment.
Looks like is_numeric would do the job: https://3v4l.org/sYolO#v8.3.6
There was a problem hiding this comment.
Not really, those are both numeric, but results in different output type: https://3v4l.org/aDslS#v8.3.6
There was a problem hiding this comment.
There is a similar open PR you might can get inspiration from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes even phpstan/phpstan#10125
Found in https://github.com/shipmonk-rnd/phpstan-rules tests when run with new 204ab27