Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count($x) > $n === true negation #3037

Merged
merged 1 commit into from
May 3, 2024

Conversation

rvanvelzen
Copy link
Contributor

@ondrejmirtes ondrejmirtes merged commit 0b6d92d into phpstan:1.10.x May 3, 2024
443 of 444 checks passed
@ondrejmirtes
Copy link
Member

Awesome, thank you!

@rvanvelzen
Copy link
Contributor Author

The same problem actually applies to strlen(), maybe one day I'll submit a PR for that too :)

@staabm
Copy link
Contributor

staabm commented May 3, 2024

The same problem actually applies to strlen(), maybe one day I'll submit a PR for that too :)

@rvanvelzen I tried replicating this problem for strlen() but did not succeed:
https://phpstan.org/r/fa21633d-7311-406a-8959-cbb4a488a61d

@rvanvelzen
Copy link
Contributor Author

@staabm the problem occurs when wrapping the condition with (...) === true: https://phpstan.org/r/8adcd9e6-501f-4e37-a175-001c753a4153

@rvanvelzen rvanvelzen deleted the bug-10952 branch May 3, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants