Improve type for predefined constant #3054
Merged
+34
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonuexe
commented
May 8, 2024
| @@ -232,7 +232,7 @@ public function resolvePredefinedConstant(string $resolvedConstantName): ?Type | |||
| return IntegerRangeType::fromInterval(1, null); | |||
| } | |||
| if ($resolvedConstantName === '__COMPILER_HALT_OFFSET__') { | |||
| return IntegerRangeType::fromInterval(0, null); | |||
| return IntegerRangeType::fromInterval(1, null); | |||
There was a problem hiding this comment.
Zero-byte PHP code itself cannot output __COMPILER_HALT_OFFSET__, so it is always >=1.
The minimum value is probably 48, but it looks unnatural, so leave it above 1.
|
I added those in what I think was my first ever phpstan contribution 😊 |
zonuexe
force-pushed
the
fix/constant-types
branch
from
ec58d6f to
201b626
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these constants are strings that are neither
''nor'0'and are replaced byAccessoryNonFalsyStringType.