NULL and null as a property default value are treated differently when overriding a parent property #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n overriding a parent property
staabm
commented
May 12, 2024
| @@ -39,7 +39,7 @@ public function processNode(Node $node, Scope $scope): array | |||
| $propertyReflection = $classReflection->getNativeProperty($node->getName()); | |||
| $propertyType = $propertyReflection->getWritableType(); | |||
| if ($propertyReflection->getNativeType() instanceof MixedType) { | |||
| if ($default instanceof Node\Expr\ConstFetch && (string) $default->name === 'null') { | |||
| if ($default instanceof Node\Expr\ConstFetch && $default->name->toLowerString() === 'null') { | |||
There was a problem hiding this comment.
btw: the origin reporter mentioned he expected 2 errors instead. since we already have this special case for native mixed I went with 0 errors for consistency.
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10987
I looked thru the codebase but could not see any other occurence with the same problem