Fix substr() type narrowing for maybe one-length result #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
| @@ -54,7 +54,7 @@ public function doMbSubstr(string $s, $nonEmpty, $positiveInt, $postiveRange, $n | |||
| assertType('string', mb_substr($s, 0, $positiveInt)); | |||
| assertType('non-empty-string', mb_substr($nonEmpty, 0, $positiveInt)); | |||
|
|
|||
| assertType('non-falsy-string', mb_substr("déjà_vu", 0, $positiveInt)); | |||
| assertType('non-empty-string', mb_substr("déjà_vu", 0, $positiveInt)); | |||
There was a problem hiding this comment.
We could keep non-falsy-string here since there is no 0 in the string constant @staabm
There was a problem hiding this comment.
I also though about that. I think such a case is pretty unlikely and supporting it would mean a lot of complication of the extension.
therefore I decided against supporting that
staabm
force-pushed
the
substr-maybeone
branch
2 times, most recently
from
d27644a
to
ed6fd44
Compare
ondrejmirtes
force-pushed
the
substr-maybeone
branch
from
ed6fd44
to
4116b39
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#11035
closes phpstan/phpstan#9804