Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Incorrect return type for SplFileObject::fgetcsv" #479

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

VincentLanglet
Copy link
Contributor

Reverts #464

Cf: #464 (comment)

@VincentLanglet
Copy link
Contributor Author

Friendly ping @ondrejmirtes, is this PR ok ? :)

@ondrejmirtes
Copy link
Member

Acording to your own comment (#464 (comment)), it can't return null without setFlags, i.e. this is a case for a type-specifying extension.

@VincentLanglet
Copy link
Contributor Author

Hi @ondrejmirtes, by looking to the psalm issues, I discovered that null can be return without setFlags
See https://3v4l.org/Y7g3v or simplified https://3v4l.org/udltZ
So I don't think a type-specifying extension is the right way to do.

@VincentLanglet
Copy link
Contributor Author

Friendly ping @ondrejmirtes

I think this PR should be preferred over a possibly type-specifying extension.

@ondrejmirtes ondrejmirtes merged commit 15485b4 into phpstan:master Jun 1, 2021
@ondrejmirtes
Copy link
Member

Thank you!

@VincentLanglet VincentLanglet deleted the revert-464-patch-1 branch June 1, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants