Fix function-map for PDOStatement pass-by-reference functions #480
Conversation
| $param = 1; | ||
|
|
||
| $statement->execute(); | ||
| $statement->bindColumn('col', $col); |
There was a problem hiding this comment.
Have you first made sure that the test fails? It won't because it's not referenced from anywhere. See NodeScopeResolver::testFileAsserts. The test needs to contain assertVariableCertainty call.
There was a problem hiding this comment.
Nope... took me 2 hours to figure out how to run a single test-method in isolation. I now made sure the test fails.
There was a problem hiding this comment.
What was the problem? vendor/bin/phing tests-fast (which is mentioned in the README) runs all essential tests in around 14 seconds on my computer.
There was a problem hiding this comment.
Ok, that was probably a problem on my end. tests-fast took about 20 minutes in my PHP 7.4-cli docker container. Probably something with xdebug...
Thanks for your help and this nice peace of software! 
There was a problem hiding this comment.
Yeah, Xdebug will slow it down, I enable it only when I need to debug something. Thank you!
|
Thank you. |
Resolves phpstan/phpstan/issues/4714.