Add ArraySum dynamic return type extension #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Apr 1, 2021
| @@ -178,4 +178,16 @@ | |||
| $fooArray = ['foo']; | |||
| $poppedFoo = array_pop($fooArray); | |||
|
|
|||
| /** @var int[] $integers */ | |||
| $sumInts = array_sum($integers); | |||
There was a problem hiding this comment.
Please use the modern way of testing this, look at NodeScopeResolver::testFileAsserts.
| return ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getReturnType(); | ||
| } | ||
|
|
||
| $arrayType = $scope->getType($functionCall->args[0]->value); |
There was a problem hiding this comment.
Empty array always returns 0, this extension should honor that. You should ask for $arrayType->isIterableAtLeastOnce()->no().
| return $itemType; | ||
| } | ||
|
|
||
| return ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getReturnType(); |
There was a problem hiding this comment.
Instead of the rest of the function, you can do just return TypeCombinator::intersect($itemType, new UnionType([new IntegerType(), new FloatType()])).
VincentLanglet
force-pushed
the
arraySUm
branch
3 times, most recently
from
60ef5e9
to
a20d860
Compare
|
It should be ok now @ondrejmirtes :) |
ondrejmirtes
approved these changes
Apr 2, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.