Add a dynamic return type for number_format #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If your locale can change, casting to float may be unsafe for making numeric strings (before php 8). In that case number_format can be used with specific params to get a numeric string
BackEndTea
force-pushed
the
dynamic-number-format
branch
from
3779eeb
to
3f05551
Compare
|
Perfect, thank you! |
|
Wow that was fast, thanks for the merge @ondrejmirtes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your locale can change, casting a float to string may be unsafe for making numeric strings (before PHP 8).
In that case number_format can be used with specific params to get a numeric string.