Support object for ReflectionClass

[VincentLanglet]

Close phpstan/phpstan#5195

[ondrejmirtes]

The code needs more advanced logic if you have an expression that can contain something else besides an object.

(new ObjectWithoutClassType())->isSuperTypeOf($valueType)->yes() will be true only for object or Foo or Foo|Bar. And that test is missing here.

Foo|string and similar types will fall through this condition.

[VincentLanglet]

Before the check

(new ObjectWithoutClassType())->isSuperTypeOf($valueType)->yes()

I have the code

foreach (TypeUtils::getConstantStrings($valueType) as $constantString) {
			if (!$this->reflectionProvider->hasClass($constantString->getValue())) {
				return $methodReflection->getThrowType();
			}
			$valueType = TypeCombinator::remove($valueType, $constantString);
		}

I thought that after the foreach, the $valueType would have been now \DateTime|\DateTimeImmutable since I used TypeCombinator::remove with the constant class-string<\DateTime>.

This is exactly why I had two case:

• \DateTime|\DateTimeImmutable|class-string<\DateTime> should have been transformed to \DateTime|\DateTimeImmutable after the foreach and then the condition returns true.
• \DateTime|\DateTimeImmutable|string would have stayed untouched and then an exception is still possible.

What is wrong ?

[ondrejmirtes]

What is wrong ?

Case new \ReflectionClass(new Foo()); is not tested. These new added tests would pass without changing src/ I believe.

[VincentLanglet]

I meant, why the current tests are failing.

[VincentLanglet]

ReflectionClass(object) is tested and works.

ReflectionClass(\DateTime|\DateTimeImmutable|class-string<\DateTime>) should not throw an exception, but PHPStan is still believing an exception can be thrown.

[VincentLanglet]

@ondrejmirtes I think it's because

try {
    new \ReflectionClass(\\DateTime::class);
} catch (\Exception $e) {

}

works but

/** @var class-string<\DateTime> $foo */
$foo;
try {
    new \ReflectionClass($foo);
} catch (\Exception $e) {

}

doesn't.

The first one is a

class PHPStan\Type\Constant\ConstantStringType#18453 (2) {
  private string $value =>
  string(8) "DateTime"
  private bool $isClassString =>
  bool(true)
}

The second one is a

class PHPStan\Type\Generic\GenericClassStringType#18511 (1) {
  private PHPStan\Type\Type $type =>
  class PHPStan\Type\ObjectType#18481 (6) {
    private string $className =>
    string(8) "DateTime"
    private ?PHPStan\Type\Type $subtractedType =>
    NULL
    private ?PHPStan\Reflection\ClassReflection $classReflection =>
    NULL
    private ?PHPStan\Type\ObjectType $cachedParent =>
    NULL
    private ?array $cachedInterfaces =>
    NULL
    private array $currentAncestors =>
    array(0) {
    }
  }
}

and TypeUtils::getConstantStrings($valueType) is only returning the first one.

All the ThrowTypeExtension I provided have the same issue.

Any idea how to fix this ?

[ondrejmirtes]

Any idea how to fix this ?

With different logic. Maybe use TypeUtils::flattenTypes() and iterate over them.

[VincentLanglet]

@ondrejmirtes It's fixed now :)

I even cought a useless @throws in the psalm codebase.

[ondrejmirtes]

Thank you!